Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49135 )
Change subject: google/asurada: support beep ......................................................................
Patch Set 1:
(3 comments)
This patch looks fine. I think we can start reviewing it.
https://review.coreboot.org/c/coreboot/+/49135/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49135/1//COMMIT_MSG@7 PS1, Line 7: google/asurada: support beep mb/google/asurada: Support beep sound
https://review.coreboot.org/c/coreboot/+/49135/1//COMMIT_MSG@10 PS1, Line 10: BUG=b:176856418
https://review.coreboot.org/c/coreboot/+/49135/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/mainboard.c:
https://review.coreboot.org/c/coreboot/+/49135/1/src/mainboard/google/asurad... PS1, Line 198: * Need a space