Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence.
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/1/src/mainboard/google/octopu...
PS1, Line 37: !gpio_get_output(GPIO_LTE_RESET)
The intention is to reduce the effect of delaying to other variants and will check with HW Eng as […]
Without the checking, more then 130ms of delay will be applied to any SKUs during shutdown no matter there is a LTE or not.
With this simple approach (not heavy), we can limit the 130ms delay for LTE sku only and necessary for power down sequence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bf6fee087c885c22363b44aa98aa61f91be90b4
Gerrit-Change-Number: 34188
Gerrit-PatchSet: 6
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 01:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment