Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37498 )
Change subject: mb/google/hatch: Add new SKU ID 3 and 4 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37498/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/37498/1/src/mainboard/google/hatch/... PS1, Line 30: /* SKU ID 2 and 4 install SSD device, hence disable it. */ The description is a bit confusing. What about: /* SKU ID 2 and 4 do not have eMMC, hence disable it. */
https://review.coreboot.org/c/coreboot/+/37498/1/src/mainboard/google/hatch/... PS1, Line 39: /* SKU ID 1 and 3 install eMMC device, hence disable it. */ Likewise, what about: /* SKU ID 1 and 3 do not have SSD, hence disable it. */