Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41980 )
Change subject: google/trogdor: Remove RO_FSG region ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41980/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/41980/1/src/mainboard/google/trogdo... PS1, Line 12: RO_VPD(PRESERVE) 228K
This seems to be more than enough. But I don't know if there is any better use of the space.
Yeah I can either put the space here or in CBFS. I don't think it's really needed on either side. Putting it here makes the FMAP alignment a bit higher, which is good.