14 Mar
2020
14 Mar
'20
11:10 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39567 )
Change subject: ec/51nb: add support for NPCE985LA0DX EC ......................................................................
Patch Set 1: Code-Review+1
looks good to me. the sio components of the ec lack some stuff in dev_infos (i'd expect some io and irq settings there), but i'm ok with adding that in a later patch, so let's get this merged for now
--
To view, visit https://review.coreboot.org/c/coreboot/+/39567
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5798fad7fd18083cde1aa647fd91ca9c5ce963b7
Gerrit-Change-Number: 39567
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 22:10:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment