Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: AMD/Picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 2:
(2 comments)
This also breaks the APU boards.
``` CC ramstage/cpu/amd/pi/00730F01/microcode_fam16h.o src/cpu/amd/pi/00730F01/microcode_fam16h.c:103:6: error: conflicting types for 'amd_update_microcode_from_cbfs' void amd_update_microcode_from_cbfs(uint32_t equivalent_processor_rev_id) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from src/cpu/amd/pi/00730F01/microcode_fam16h.c:7: src/include/cpu/amd/microcode.h:5:6: note: previous declaration of 'amd_update_microcode_from_cbfs' was here void amd_update_microcode_from_cbfs(u16 equivalent_processor_rev_id); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
https://review.coreboot.org/c/coreboot/+/41719/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41719/2//COMMIT_MSG@6 PS2, Line 6: : AMD/Picasso Please make it lowercase.
https://review.coreboot.org/c/coreboot/+/41719/2/src/soc/amd/picasso/microco... File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/2/src/soc/amd/picasso/microco... PS2, Line 2: /* This file is part of the coreboot project. */ This line should be removed.