Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34598 )
Change subject: lib/bootsplash: Log bootsplash dimensions and framebuffer dimensions
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34598/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34598/4//COMMIT_MSG@9
PS4, Line 9: The bootsplash.jpg needs to match the framebuffer resolution.
What does the code do when they don't match? Does it silently fail?
How about just logging the dimensions in case of a mismatch? This would allow for a more explicit log message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a06d53c0134b99d3e9e6d3eda9fa30fca9ef7d
Gerrit-Change-Number: 34598
Gerrit-PatchSet: 4
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Aug 2019 09:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment