Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39976 )
Change subject: mb/siemens/chili: Add new mainboard ......................................................................
Patch Set 33:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39976/12/src/mainboard/siemens/chil... File src/mainboard/siemens/chili/variants/base/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/39976/12/src/mainboard/siemens/chil... PS12, Line 12: -- For a three-pipe setup, bandwidth is shared between the 2nd and
We discussed this with Nico, and it's apparently a limitation of platforms with Ivy Bridge. […]
Sorry, that's probably my copy-pasta. Please remove the whole comment.
Actually, the whole file is copy-pasta. Please update. CFL doesn't have `Analog` at all. I only recall a single DP (potentially DP++ with HDMI capability) and eDP.
https://review.coreboot.org/c/coreboot/+/39976/6/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/ec.c:
https://review.coreboot.org/c/coreboot/+/39976/6/src/mainboard/siemens/field... PS6, Line 16: BOOMER
Hello Sebastian, thanks for the clarification :)
Angel, is it ok to resolve this without adding comments? I think the macro names explain themself when one has the device at hand (at least as far as I could comment them anyway). The EC chip model really shouldn't matter.
https://review.coreboot.org/c/coreboot/+/39976/6/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/base/board_info.txt:
https://review.coreboot.org/c/coreboot/+/39976/6/src/mainboard/siemens/field... PS6, Line 1: Board name: Field PG M6
Well, "Field PG M6" is what it said on all the documentation. And the […]
Board name has been reduce to "Chili base board" in the meantime.