Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel...
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel...
PS3, Line 64:
: config DEVICETREE
: string
: default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
I'm a bit confused. There is no devicetree.cb in baseboard. Do we want to do it in this patch?
Add a patch with a base devictree.cb and with variants overriding it with overridetree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf723ada53dc441cb9fabc8efb1dcd3da8e0991c
Gerrit-Change-Number: 36685
Gerrit-PatchSet: 3
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 10 Nov 2019 10:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-MessageType: comment