Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44416 )
Change subject: mb/intel/jasperlake_rvp: Configure GPIOs related to UFC ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl... PS2, Line 83: 0 shouldn't this be 1? or driver drivers it from PR0?
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl... PS2, Line 89: PLTRST DEEP
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl... PS2, Line 92: PLTRST DEEP
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl... PS2, Line 113: PLTRST DEEP