Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41593 )
Change subject: AGESA f14 boards: Drop useless family definitions
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/persimmon...
File src/mainboard/amd/persimmon/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/persimmon...
PS3, Line 31: #define BLDOPT_REMOVE_FAMILY_14_SUPPORT FALSE
Shouldn't this line be preserved? According to the instruction in a comment above...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fc6ba94cde66a238da9705fc42330b9e7682800
Gerrit-Change-Number: 41593
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 May 2020 20:13:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment