[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common/block/gpio: Add gpio_pm_configure() function

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )

Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/gpio/gpio... 
File src/soc/intel/common/block/gpio/gpio.c:

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/gpio/gpio... 
PS6, Line 625: misccfg_pm_mask[i]
> Shouldn't the mask be always 0x3F so that you can actually set the value (0 or 1) that is requested  […]

Done

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/include/i... 
File src/soc/intel/common/block/include/intelblocks/gpio.h:

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/include/i... 
PS6, Line 25: 
            : union gpio_misc_pm {
            : 	uint8_t config;
            : 	struct {
            : 		uint8_t gdlcgen : 1;
            : 		uint8_t gpdpcgen : 1;
            : 		uint8_t gsxslcgen : 1;
            : 		uint8_t gprtcdlcgen : 1;
            : 		uint8_t gprcompcdlcgen : 1;
            : 		uint8_t gpsidedpcgen : 1;
            : 		uint8_t reserved : 2;
            : 	} bit;
            : };
            :
> Agree with Furquan here, the order of bitfields is compiler/implementation defined and should be avo […]

Done