Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38352 )
Change subject: sb/intel/i82371eb: Add support for reconfiguring GPO22/23 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/chip.h:
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... PS4, Line 32: int gpo22:1; : int gpo23:1; : int pad:5;
pad is padding to whole bytes. […]
I don't think padding is required. After all, the struct isn't used as a whole. Also, the struct isn't packed, so the padding would be added automatically.
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/isa.c:
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... PS4, Line 89: 32
Previously only the low 16 bits were changed so that worked. […]
Ack