Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40281 )
Change subject: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions ......................................................................
Patch Set 1:
(4 comments)
Very nice. Welcome to coreboot!
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions I’d use:
mb/lenovo/t420s/devicetree: Enable USB 3.0 controller
Fix PCIe port definitions to …
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@9 PS1, Line 9: The NEC uPD720200A USB 3.0 controller on the T420s is actually connected to Please wrap lines after 72/75 characters.
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@10 PS1, Line 10: Enabled RP#5, disabled RP#7 and : updated comments accordingly. So, enable RP#5, disable RP#7, and update comments accordingly.
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@12 PS1, Line 12: Test=USB 3.0 controller shows up in lspci.