Very nice. Welcome to coreboot!
View Change
4 comments:
Commit Message:
Patch Set #1, Line 7: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions
I’d use:
mb/lenovo/t420s/devicetree: Enable USB 3.0 controller
> Fix PCIe port definitions to …
Patch Set #1, Line 9: The NEC uPD720200A USB 3.0 controller on the T420s is actually connected to
Please wrap lines after 72/75 characters.
Patch Set #1, Line 10:
Enabled RP#5, disabled RP#7 and
updated comments accordingly.
So, enable RP#5, disable RP#7, and update comments accordingly.
Patch Set #1, Line 12:
Test=USB 3.0 controller shows up in lspci.
To view, visit change 40281. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21ac72fd5632e552bdcdbd573cf92b433ed545ff
Gerrit-Change-Number: 40281
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002895
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 07:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment