Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, EricR Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )
Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................
Patch Set 20:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48345/comment/9de2ef66_6926e49e
PS20, Line 10: ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
: relevant Kconfig required to enable eNEM for Alder Lake.
That’s still a to-do?
https://review.coreboot.org/c/coreboot/+/48345/comment/7d356bcd_b80e7274
PS20, Line 13: selects
Nit: Use imperative mood? select?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Gerrit-Change-Number: 48345
Gerrit-PatchSet: 20
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 07:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment