Change in coreboot[master]: soc/intel/alderlake: Select USE_CAR_NEM_ENHANCED_V3 for ADL

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: soc/intel/alderlake: Select USE_CAR_NEM_ENHANCED_V3 for ADL
......................................................................

soc/intel/alderlake: Select USE_CAR_NEM_ENHANCED_V3 for ADL

TEST=Able to build and boot ADLRVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/1

diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig
index 7e693cb..df2967c 100644
--- a/src/soc/intel/alderlake/Kconfig
+++ b/src/soc/intel/alderlake/Kconfig
@@ -22,7 +22,6 @@
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SMI_HANDLER
    select IDT_IN_EVERY_STAGE
-	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
    select INTEL_GMA_ACPI
    select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
    select IOAPIC
@@ -61,6 +60,7 @@
    select UDK_202005_BINDING
    select DISPLAY_FSP_VERSION_INFO
    select HECI_DISABLE_USING_SMM
+	select USE_CAR_NEM_ENHANCED_V3

config MAX_CPUS
    int

Change in coreboot[master]: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

[Subrata Banik (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#3).

Change subject: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL
......................................................................

soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

TEST=Able to build and boot ADLRVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/3

Change in coreboot[master]: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

[Subrata Banik (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#4).

Change subject: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL
......................................................................

soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

BUG=b:168820083
TEST=Able to build and boot ADLRVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/4

Change in coreboot[master]: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

[Subrata Banik (Code Review)]

Attention is currently required from: Tim Wawrzynczak.
Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#6).

Change subject: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL
......................................................................

soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/6

Change in coreboot[master]: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#8).

Change subject: soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL
......................................................................

soc/intel/alderlake: Select required Kconfig for eNEM flow on ADL

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/8

Change in coreboot[master]: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#10).

Change subject: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL
......................................................................

soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

This patch enables eNEM flow for Alder Lake SoC hence drop INTEL_CAR_NEM
Kconfig from SoC. ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
relevant Kconfig required to enable eNEM for Alder Lake.

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/soc/intel/alderlake/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/10

Change in coreboot[master]: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Subrata Banik, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL
......................................................................

Patch Set 19: Code-Review-1

(1 comment)

Patchset:

PS19: 
Let's hang back on this one for a little while because of the incompatibility with previous board revisions.

Change in coreboot[master]: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL
......................................................................

Patch Set 19:

(1 comment)

Patchset:

PS19:
> Let's hang back on this one for a little while because of the incompatibility with previous board re […]

Make sense to me, just a thought, do you think we can move this eNEM selection to board specific Kconfig so that atleast on ADLRVP (where we don't use ES0 samples anymore), we can continue our validation with eNEM rather just park this feature enablement may be for next several months and then ran into some unknown issue (if any) while we actually wish to enable this feature.

Change in coreboot[master]: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Subrata Banik, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL
......................................................................

Patch Set 19:

(1 comment)

Patchset:

PS19:
> Make sense to me, just a thought, do you think we can move this eNEM selection to board specific Kco […]

Absolutely, can be mainboard-specific for now.

Change in coreboot[master]: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: soc/intel/alderlake: Drop INTEL_CAR_NEM Kconfig select on ADL
......................................................................

Patch Set 19:

(1 comment)

Patchset:

PS19:
> Absolutely, can be mainboard-specific for now.

Thanks Tim, let me then enable it for ADLRVP so we can ensure validation, what i will do is that

1. Submit CL to migrate all `select INTEL_CAR_NEM` selection to ADL mbs we have.
2. ADLRVP CL just drop this support so we are sure other are not breaking.

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#20).

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

This patch enables eNEM flow for Alder Lake SoC hence drop INTEL_CAR_NEM
Kconfig from ADL-P RVP. ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
relevant Kconfig required to enable eNEM for Alder Lake.

Additionally, selects INTEL_CAR_NEM Kconfig for ADL-M RVPs from Kconfig.name.

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Kconfig.name
2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/20

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Paul Menzel (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, EricR Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 20:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48345/comment/9de2ef66_6926e49e 
PS20, Line 10: ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
             : relevant Kconfig required to enable eNEM for Alder Lake.
That’s still a to-do?

https://review.coreboot.org/c/coreboot/+/48345/comment/7d356bcd_b80e7274 
PS20, Line 13: selects
Nit: Use imperative mood? select?

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, EricR Lai.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Meera Ravindranath, Patrick Rudolph, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48345

to look at the new patch set (#21).

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

This patch enables eNEM flow for Alder Lake SoC hence drop INTEL_CAR_NEM
Kconfig from ADL-P RVP. ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
relevant Kconfig required to enable eNEM for Alder Lake.

Additionally, select INTEL_CAR_NEM Kconfig for ADL-M RVPs from Kconfig.name.

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Kconfig.name
2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48345/21

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Meera Ravindranath, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 20:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48345/comment/95c4c8f1_ba9ec467 
PS20, Line 10: ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
             : relevant Kconfig required to enable eNEM for Alder Lake.
> That’s still a to-do?

Yes, atleast for ADL-P RVP we have enabled that, remaining board variant still has due to SoC dependencies

https://review.coreboot.org/c/coreboot/+/48345/comment/004d428c_5dfd4743 
PS20, Line 13: selects
> Nit: Use imperative mood? select?

Ack

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Meera Ravindranath, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 21:

(1 comment)

File src/mainboard/intel/adlrvp/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48345/comment/af72dcd6_9f09bfb8 
PS21, Line 20: 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
             : 
             : config BOARD_INTEL_ADLRVP_M_EXT_EC
             : 	bool "Alderlake-M RVP with Chrome EC"
             : 	select INTEL_LPSS_UART_FOR_CONSOLE
             : 	select DRIVERS_INTEL_MIPI_CAMERA
             : 	select SOC_INTEL_COMMON_BLOCK_IPU
             : 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
These shouldn't be encessary, the BOARD_SPECIFIC_OPTIONS are covered by all 4 BOARD_INTEL_ADLRVP_* types ?

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Meera Ravindranath, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 21:

(1 comment)

File src/mainboard/intel/adlrvp/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48345/comment/ca0c2b51_7b4a0ee8 
PS21, Line 20: 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
             : 
             : config BOARD_INTEL_ADLRVP_M_EXT_EC
             : 	bool "Alderlake-M RVP with Chrome EC"
             : 	select INTEL_LPSS_UART_FOR_CONSOLE
             : 	select DRIVERS_INTEL_MIPI_CAMERA
             : 	select SOC_INTEL_COMMON_BLOCK_IPU
             : 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
> These shouldn't be encessary, the BOARD_SPECIFIC_OPTIONS are covered by all 4 BOARD_INTEL_ADLRVP_* t […]

I don't know Tim, what all SoC is being used for ADL-M so, don't really want to enable eNEM for them by default as I'm yet to hear their validation feedback.

Once I would get full validation data from ADL-M, we could just enable eNEM for all ADL-RVPs and remove those from here as well. Does that make sense to you ?

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Meera Ravindranath, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 21: Code-Review+2

(1 comment)

File src/mainboard/intel/adlrvp/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48345/comment/afb6a98a_d1b4a930 
PS21, Line 20: 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
             : 
             : config BOARD_INTEL_ADLRVP_M_EXT_EC
             : 	bool "Alderlake-M RVP with Chrome EC"
             : 	select INTEL_LPSS_UART_FOR_CONSOLE
             : 	select DRIVERS_INTEL_MIPI_CAMERA
             : 	select SOC_INTEL_COMMON_BLOCK_IPU
             : 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
> I don't know Tim, what all SoC is being used for ADL-M so, don't really want to enable eNEM for them […]

Ack

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Meera Ravindranath, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 21:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48345/comment/d2dc1dd8_3c5c1d31 
PS20, Line 10: ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
             : relevant Kconfig required to enable eNEM for Alder Lake.
> Yes, atleast for ADL-P RVP we have enabled that, remaining board variant still has due to SoC depend […]

anything further @Paul ? can we mark this resolve ?

File src/mainboard/intel/adlrvp/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/48345/comment/5576f866_51f14ea5 
PS21, Line 20: 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
             : 
             : config BOARD_INTEL_ADLRVP_M_EXT_EC
             : 	bool "Alderlake-M RVP with Chrome EC"
             : 	select INTEL_LPSS_UART_FOR_CONSOLE
             : 	select DRIVERS_INTEL_MIPI_CAMERA
             : 	select SOC_INTEL_COMMON_BLOCK_IPU
             : 	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
> Ack

thanks Tim

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Meera Ravindranath, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

Patch Set 21:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48345/comment/462af5e8_11b9901e 
PS20, Line 10: ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
             : relevant Kconfig required to enable eNEM for Alder Lake.
> anything further @Paul ? can we mark this resolve ?

Ack

Change in coreboot[master]: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48345 )

Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................

mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP

This patch enables eNEM flow for Alder Lake SoC hence drop INTEL_CAR_NEM
Kconfig from ADL-P RVP. ALDERLAKE_CAR_ENHANCED_NEM Kconfig will select all
relevant Kconfig required to enable eNEM for Alder Lake.

Additionally, select INTEL_CAR_NEM Kconfig for ADL-M RVPs from Kconfig.name.

BUG=b:168820083
TEST=Able to build and boot ADL-P RVP using eNEM mode.

Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48345
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Kconfig.name
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig
index 6e41e02..eed3b30 100644
--- a/src/mainboard/intel/adlrvp/Kconfig
+++ b/src/mainboard/intel/adlrvp/Kconfig
@@ -25,7 +25,6 @@
    select MAINBOARD_HAS_TPM2 if BOARD_INTEL_ADLRVP_M_EXT_EC
    select MAINBOARD_HAS_SPI_TPM_CR50 if BOARD_INTEL_ADLRVP_M_EXT_EC
    select SPI_TPM if BOARD_INTEL_ADLRVP_M_EXT_EC
-	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED

config CHROMEOS
    select GBB_FLAG_FORCE_DEV_SWITCH_ON
diff --git a/src/mainboard/intel/adlrvp/Kconfig.name b/src/mainboard/intel/adlrvp/Kconfig.name
index 341b717..c53bab2 100644
--- a/src/mainboard/intel/adlrvp/Kconfig.name
+++ b/src/mainboard/intel/adlrvp/Kconfig.name
@@ -17,9 +17,11 @@
    select MAINBOARD_USES_IFD_EC_REGION
    select DRIVERS_INTEL_MIPI_CAMERA
    select SOC_INTEL_COMMON_BLOCK_IPU
+	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED

config BOARD_INTEL_ADLRVP_M_EXT_EC
    bool "Alderlake-M RVP with Chrome EC"
    select INTEL_LPSS_UART_FOR_CONSOLE
    select DRIVERS_INTEL_MIPI_CAMERA
    select SOC_INTEL_COMMON_BLOCK_IPU
+	select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED