Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41785 )
Change subject: cpu/x86/mtrr.h: Get rid of commonlib/helpers.h dependency ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41785/1//COMMIT_MSG@11 PS1, Line 11: definition.
Where is the ALIGN() macro being used in the CACHE_ROM_* macros? Sorry, I poked around and couldn't […]
Could we be more explicit that this is conflicting with ld ALIGN keyword? I was confused where the conflict was coming from, but saw comments in CB:30872 that explain it more.