Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Subrata Banik, Michael Niewöhner.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48658 )
Change subject: soc/intel/*: Add TPM decode range to soc_get_fixed_mmio_ranges()
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/tigerlake/espi.c:
https://review.coreboot.org/c/coreboot/+/48658/comment/c79706ab_0e6b20a6
PS2, Line 33: 0x8000
Which document (title and/or doc number) did you find this information in? It would be good to menti […]
Done
File src/soc/intel/xeon_sp/lpc.c:
https://review.coreboot.org/c/coreboot/+/48658/comment/e6195ae7_f4e32f07
PS2, Line 13: { CONFIG_CRB_TPM_BASE_ADDRESS, 0x8000 },
: { CONFIG_TPM_TIS_BASE_ADDRESS, 0x8000 },
:
AFAIUI these Kconfigs are only there for overriding the fixed address in case the tpm doesn't comply […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f2257b55a712b936763cfd289c2c4b1633e8049
Gerrit-Change-Number: 48658
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 14 Jan 2021 10:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment