build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31955 )
Change subject: soc/intel/icelake: Pass FSP-M/S UPD as per ICL requirement ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31955/1/src/soc/intel/icelake/fsp_params.c File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/#/c/31955/1/src/soc/intel/icelake/fsp_params.c@3... PS1, Line 38: for (int i = 0; i < CONFIG_SOC_INTEL_I2C_DEV_MAX; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/1/src/soc/intel/icelake/fsp_params.c@4... PS1, Line 48: for (int i = 0; i < CONFIG_SOC_INTEL_UART_DEV_MAX; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/1/src/soc/intel/icelake/fsp_params.c@6... PS1, Line 68: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/1/src/soc/intel/icelake/fsp_params.c@7... PS1, Line 72: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) { braces {} are not necessary for single statement blocks