13 Oct
2020
13 Oct
'20
2:23 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46286 )
Change subject: superio/nuvoton: Only set bit 7 of global CR 0x2a for COM A ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46286/2/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/46286/2/src/superio/nuvoton/common/... PS2, Line 58: (1 << 7)
Parentheses look odd between commas. Could just be me, though.
yeah, those aren't needed; doesn't hurt to have theme there though
--
To view, visit https://review.coreboot.org/c/coreboot/+/46286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ded9dab3985c4c8e5c45af354ef44af482e18c2
Gerrit-Change-Number: 46286
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Teo Boon Tiong boon.tiong.teo@intel.com
Gerrit-Comment-Date: Tue, 13 Oct 2020 11:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment