Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 )
Change subject: amdfwtool: Add --fsp-version option
......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/74266/comment/9e7ae431_e62b5ff6
PS1, Line 860: if (!(index->filename))
: continue;
It can be part of for-loop condition.
`index->type != AMD_FW_INVALID && index->filename`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74266
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idaa3a02ace524f44cfa656e34308bd896016dff6
Gerrit-Change-Number: 74266
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 10:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment