Attention is currently required from: Furquan Shaikh. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52181/comment/a806baf5_4ffb2c5d PS17, Line 17: Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com
Duplicate Signed-off-by line.
Done
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/42e8eb3c_48ea4bab PS17, Line 52: acpi_get_sleep_type()
nit: This call can be made at the called site as well i.e. […]
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/9bc4cf71_ab2a96e5 PS17, Line 7: #include <gpio.h>
I don't think this is required anymore.
Done
https://review.coreboot.org/c/coreboot/+/52181/comment/d75948c8_c78332eb PS17, Line 9: #include <soc/smi.h>
Why is this required?
Done