Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34090 )
Change subject: cpu/x86: Fix MSR_PLATFORM_INFO definition
......................................................................
Patch Set 4:
I wouldn't mind common, non-architectural MSR definitions in
a common place. As long as it's clear from the prefix, MSR_
instead of IA32_, that wouldn't seem bad, would it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibeed022dc2ba2e90f71511f9bd2640a7cafa5292
Gerrit-Change-Number: 34090
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 07 Jul 2019 11:30:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment