Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37154 )
Change subject: Kconfig: Drop the C_ENVIRONMENT_BOOTBLOCK symbol ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/Makefile.inc@1... PS1, Line 131: else # !ROMCC_BOOTBLOCK
without ! ?
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/assembly_entry... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/assembly_entry... PS1, Line 22: * clear .bss/CAR_GLOBAL variables that are stage specific.
I think you can already wipe CAR_GLOBAL here. It could have been done earlier but I overlooked it.
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/include/arch/c... File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/include/arch/c... PS1, Line 291: * When using not using a romcc bootblock the car_stage_entry()
-using
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/37154/1/src/arch/x86/memlayout.ld@5... PS1, Line 52: /* arch/x86/bootblock.ld contains the logic for the romcc bootblock linking. */
Maybe have literal ROMCC_BOOTBLOCK here so we remember to revisit this line.
Done
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/37154/1/src/cpu/intel/car/romstage.... PS1, Line 75: /* This wrapper enables easy transition away from ROMCC_BOOTBLOCK
trailing whitespace
Done