Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37401 )
Change subject: mb/*/*: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/inagua/Bi... File src/mainboard/amd/inagua/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/inagua/Bi... PS1, Line 60: Data8 = pm_io_read8(0x26); This would pm_io_read16(). But we could just s/AcpiMmioAddr/AMD_SB_ACPI_MMIO_ADDR/ here.
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/inagua/Bi... PS1, Line 137: /* Get SB MMIO Base (AcpiMmioAddr) */ As above, AMD_SB_ACPI_MMIO_ADDR ?
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/lamar/rom... File src/mainboard/amd/lamar/romstage.c:
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/lamar/rom... PS1, Line 46: pm_io_write8(0x24, 1); This PM 0x24 bit1 to enable ACPIMMIO in general. acpimmio_decode_enable() ?
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/olivehill... File src/mainboard/amd/olivehill/mptable.c:
https://review.coreboot.org/c/coreboot/+/37401/1/src/mainboard/amd/olivehill... PS1, Line 102: #if 0 Separate commit for these removals please.