View Change

4 comments:

• File src/mainboard/amd/inagua/BiosCallOuts.c:

  • Patch Set #1, Line 60: Data8 = pm_io_read8(0x26);

    This would pm_io_read16(). But we could just s/AcpiMmioAddr/AMD_SB_ACPI_MMIO_ADDR/ here.

  • Patch Set #1, Line 137: /* Get SB MMIO Base (AcpiMmioAddr) */

    As above, AMD_SB_ACPI_MMIO_ADDR ?

• File src/mainboard/amd/lamar/romstage.c:

  • Patch Set #1, Line 46: pm_io_write8(0x24, 1);

    This PM 0x24 bit1 to enable ACPIMMIO in general. acpimmio_decode_enable() ?

• File src/mainboard/amd/olivehill/mptable.c:

  • Patch Set #1, Line 102: #if 0

    Separate commit for these removals please.

To view, visit change 37401. To unsubscribe, or for help writing mail filters, visit settings.