Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for VL822 USB hub
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
What datasheet did you ues?
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/f9ae4209_904dc6e0
PS2, Line 78: .read_resources = noop_read_resources,
: .set_resources = noop_set_resources,
: .scan_bus = scan_static_bus,
: .acpi_fill_ssdt = usb_vl822_acpi_fill_ssdt,
: .acpi_name = usb_vl822_acpi_name
I think in other files, tabulators are used to align the equal signs.
https://review.coreboot.org/c/coreboot/+/63968/comment/9e12247d_67ebb451
PS2, Line 91: ViaLabs
Via Labs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 03 May 2022 07:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment