Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33548 )
Change subject: sb/intel/bd82x6x: Set up io_gen_dec in romstage based on devicetree
......................................................................
Patch Set 2: Code-Review-2
This patch depends on the next, while the next depends on this one.
Please use 3 commits to not introduce a temporary regression:
1. Duplicate settings to devicetree
2. Use devicetree settings and romstage code
3. Remove duplicated romstage code
With those three I'm happy to give +2 instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie59b8272c69231d6dffccee30b4d3c84a7e83e8f
Gerrit-Change-Number: 33548
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Jun 2019 07:04:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment