16 Oct
2019
16 Oct
'19
10:24 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... PS5, Line 16: config USE_ACPI_PM_TIMER I know this just mimics the Kconfig name above. But "use" is really confusing, coreboot will never use this timer. I think `ENABLE_ACPI_PM_TIMER` would catch it much better.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36034
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348
Gerrit-Change-Number: 36034
Gerrit-PatchSet: 5
Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 08:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment