Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32076/14/MAINTAINERS
File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/32076/14/MAINTAINERS@330
PS14, Line 330: F: src/mainboard/protectli/
I’d prefer a separate commit for this.
Removed from this patch
https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va...
File src/mainboard/protectli/vault_bsw/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va...
PS15, Line 12: register "PcdIgdDvmt50PreAlloc" = "1"
Grepped the whole project directory looking for this string and found nothing. […]
NVM, found it in chip.h in SoC. Still weird that grep did not catch it...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I553fd3a89299314a855f055014ca7645100e12e7
Gerrit-Change-Number: 32076
Gerrit-PatchSet: 17
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Mar 2020 12:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment