Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48584 )
Change subject: Add more traceable SPI commands
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/em100/+/48584/4/trace.c
File trace.c:
https://review.coreboot.org/c/em100/+/48584/4/trace.c@264
PS4, Line 264: always decode 4 bytes
I am not sure I understand this comment.
https://review.coreboot.org/c/em100/+/48584/4/trace.c@321
PS4, Line 321: address += 16;
Isn't this only for address_type != ADDR_NONE? Probably doesn't matter since it will not be used in the for loop above?
--
To view, visit
https://review.coreboot.org/c/em100/+/48584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I9002253bf6eb7d60c90cdb75492076d5c5c48f21
Gerrit-Change-Number: 48584
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 00:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment