[coreboot-gerrit] Change in coreboot[master]: drivers/smmstore: Implement SMMSTORE version 2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )

Change subject: drivers/smmstore: Implement SMMSTORE version 2
......................................................................

Patch Set 22:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/Kconf... 
File src/drivers/smmstore/Kconfig:

https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/Kconf... 
PS21, Line 12: default y if PAYLOAD_TIANOCORE
> Good point. I'll change the default to n for now.

Done

https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/smi.c 
File src/drivers/smmstore/smi.c:

https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/smi.c... 
PS21, Line 144: usually
> That comment was already in the existing code. I think it can be dropped.

Done

https://review.coreboot.org/c/coreboot/+/40520/21/src/include/smmstore.h 
File src/include/smmstore.h:

https://review.coreboot.org/c/coreboot/+/40520/21/src/include/smmstore.h@43 
PS21, Line 43: * FIXME: The data format isn't specified.
> I'm not sure. I think not. […]

This refers to the data stored within the blocks. The data format shouldn't need to be specified, as this would work like a block device.

I messaged Patrick about it, but I didn't reach any conclusions (I timed out waiting for a reply).