Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47260 )
Change subject: device: Add pci_s_dev_is_wake_source function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47260/1/src/device/pci_ops.c File src/device/pci_ops.c:
https://review.coreboot.org/c/coreboot/+/47260/1/src/device/pci_ops.c@82 PS1, Line 82: pci_s_dev_is_wake_source Do we need this separate _s_ call implemented for this function? `pci_dev_is_wake_source()` calls pci_find_capability and pci_read_config16 -- both functions work irrespective of whether ENV_PCI_SIMPLE_DEVICE is defined or not. So, it should be safe to just move `pci_dev_is_wake_source()` from pci_device.c to this file.