John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32924 )
Change subject: soc/intel/common: Add negative sign check for variable bios_size ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32924/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32924/1//COMMIT_MSG@11 PS1, Line 11: varialbe
variable
corrected.
https://review.coreboot.org/#/c/32924/1//COMMIT_MSG@14 PS1, Line 14: Signed-off-by: John Zhao john.zhao@intel.com
By default the Signed-off-by line is below the Change-Id line.
done.
https://review.coreboot.org/#/c/32924/1/src/soc/intel/common/block/fast_spi/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/#/c/32924/1/src/soc/intel/common/block/fast_spi/... PS1, Line 239: (!bios_size || (bios_size < 0))
Make it one check? […]
done.