Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41949 )
Change subject: soc/mediatek/mt8183: Add ddr geometry to support 6GB, 8GB DDR bootup
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41949/8/src/soc/mediatek/mt8183/emi...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/41949/8/src/soc/mediatek/mt8183/emi...
PS8, Line 393: dramc_err("density err!\n");
Done
Forgot to change this?
https://review.coreboot.org/c/coreboot/+/41949/10/src/soc/mediatek/mt8183/in...
File src/soc/mediatek/mt8183/include/soc/dramc_param.h:
PS10:
Do we really need to modify this file? Could we move enum DRAMC_PARAM_GEOMETRY_TYPE to emi.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fdf50b75c6a552c0a889f21e1a81ab4b9a305fa
Gerrit-Change-Number: 41949
Gerrit-PatchSet: 10
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Tue, 09 Jun 2020 01:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Duan huayang
huayang.duan@mediatek.com
Gerrit-MessageType: comment