Attention is currently required from: Varshit B Pandya, Furquan Shaikh, Rizwan Qureshi, Meera Ravindranath, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52013 )
Change subject: mb/google/brya: Enable WFC
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52013/comment/a9827e69_dfc71fd3
PS8, Line 179: 3
Could we get an SoC #define or enum for these?
https://review.coreboot.org/c/coreboot/+/52013/comment/1428dc6c_5dca9179
PS8, Line 180: 1
Same with this, a set of #defines or enums would be nice
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52013/comment/efa7454b_16626660
PS1, Line 220: params->PchSerialIoI2cSdaPinMux[4] = GPIO_VER2_LP_MUXING_SERIALIO_I2C4_SDA_GPP_D13;
: params->PchSerialIoI2cSclPinMux[4] = GPIO_VER2_LP_MUXING_SERIALIO_I2C4_SCL_GPP_D14;
ACK, this is not the final change we were trying out few things to see if the detection works
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52013
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e9c28f255bdf86a68ce80a4f853be4e7c7ccfe
Gerrit-Change-Number: 52013
Gerrit-PatchSet: 8
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Shobhit Srivastava
shobhit.srivastava@intel.com
Gerrit-CC: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 May 2021 22:10:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment