Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: sc7180: Add support for sn65dsi86 bridge.
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42899/3/src/drivers/ti/sn65dsi86bri...
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/42899/3/src/drivers/ti/sn65dsi86bri...
PS3, Line 337: 360
Datasheet says to wait for max 400 ms
Then let's wait 400ms instead of 360ms?
In general I think this is fine since this is only a timeout. I expect that in most "normal" cases it will be a lot faster. I'm more worried about those plain mdelay() that we have in some places.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a68f3241f0ba316c261a73c2f6d30fe6c3ccdc
Gerrit-Change-Number: 42899
Gerrit-PatchSet: 6
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Jul 2020 01:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment