[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )

Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................

Patch Set 1:

(2 comments)

Subrata, is there anything you want to add to justify your score?

https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc... 
PS1, Line 274:
> Do you recommend the user now to select what is CAR option now ?

This had a prompt all along, so I expect everyone to select what suits their
use case. Generally, I would recommend to leave it at the new default
`USE_CANNONLAKE_CAR_NEM_ENHANCED`.

https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc... 
PS1, Line 273: Cache-as-ram implementation
> Where do these prompts get their default value from, now?

If no `default` is given for a choice, it simply defaults to the first available entry.