Attention is currently required from: Arthur Heymans, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74717?usp=email )
Change subject: soc/amd/common/data_fabric/domain: provide scan_bus and read_resources ......................................................................
Patch Set 14:
(4 comments)
Patchset:
PS13:
Didn't compare with what _fill_ssdt does, yet.
that one gets added in the next patch; just saw that this patch already contains a reference to it in a comment; moved that comment to the next patch
File src/soc/amd/common/block/data_fabric/Kconfig:
https://review.coreboot.org/c/coreboot/+/74717/comment/9ea4ed07_800d43b8 : PS13, Line 13: ist
*it*
Done
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/74717/comment/5f9cd5f9_83743257 : PS12, Line 39: D18F0_MMIO_SHIFT
Couldn't find a register description any public doc about it?
looks like this isn't in the public docs, but basically the register contains bits 16..47 and the D18F0_MMIO_SHIFT macro is 16 to convert the raw values to the actual addresses. added a comment to make that a bit clearer
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/74717/comment/095762ca_88a1e42b : PS13, Line 77: dev
If we expect `dev` always to be a domain device, maybe call it `domain`. Same below.
i like the idea. done and i hope that i re-pushed all patches that were affected by this change