Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39414 )
Change subject: nb/intel/pineview: Clean up code and comments
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39414/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39414/4//COMMIT_MSG@8
PS4, Line 8:
I didn't add macros for any GPIOs. Are you referring to all those things in `mchbar_regs. […]
Done, I think
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29104b0c24d66c6f49844f99d62ec433bb31bdaf
Gerrit-Change-Number: 39414
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Mar 2020 10:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment