HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37710 )
Change subject: Revert "{northbridge,soc,southbridge}: Don't use both of _ADR and _HID" ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patch Set 1:
IASL will complain as we are using _ADR and _HID at the same time. we have to remove one of them.
In most cases I've looked into, there are deeper issues, so simply removing either of them won't do. One has to look into each case individually and fix the code. Sometimes the current code seems to have only one ASL `Device` node for two devices (e.g. PCI root bus and a PCI device). In theses cases, the code has to be split into two devices. In case of the Intel serial i/o devices, the _ADR or _HID should be generated at runtime in an SSDT, so we can decide, based on the devicetree, which it will be. After fixing the code, there should be much less cases of _ADR and _HID being specified.
https://review.coreboot.org/c/coreboot/+/37710/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37710/3//COMMIT_MSG@17 PS3, Line 17: would you add that this revert is just a workaround for the moment and we absolutely need to fix those files to be ACPI compliant.