Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
What VR does the board have?
I don't remember off the top of my head, but this was copy-pasted when doing the original port and removing it shows no adverse effects.
Well, I'm not sure if not entering / not exiting PS4 would really show that obvious. That would need to be checked by poking VR registers. So, when Matt can tell me which VR it is, I can see if I have a datasheet :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15a68b59bc512e571b9590007ea64561b3f3dae1
Gerrit-Change-Number: 47184
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 03 Nov 2020 23:46:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment