Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45627 )
Change subject: superio/common: Fix NULL pointer dereferences ......................................................................
superio/common: Fix NULL pointer dereferences
Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.
Found-by: Coverity CID 1419488 TEST=None
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45627 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/device_util.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/device/device_util.c b/src/device/device_util.c index 22c3db1..452a87b 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -519,7 +519,7 @@ end = resource_end(resource); buf[0] = '\0';
- if (resource->flags & IORESOURCE_PCI_BRIDGE) { + if (dev->link_list && (resource->flags & IORESOURCE_PCI_BRIDGE)) { snprintf(buf, sizeof(buf), "bus %02x ", dev->link_list->secondary); }