Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33383 )
Change subject: nb/intel/nehalem: Prevent out of bounds read
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33383/3/src/northbridge/intel/nehalem/ramini...
File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/33383/3/src/northbridge/intel/nehalem/ramini...
PS3, Line 599: die("RAM init: Decoded SPD DRAM freq is slower than the controller minimum!");
Ugh... Maybe omit "DRAM" and change "is slower" to "lower". Shouldn't impact readability too much.
The line length was recently increased to 96 anyway, so I've kinda just been ignoring these warnings as long as it fits under that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8ed1293adfe0866781bd638323977abd110777e
Gerrit-Change-Number: 33383
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment