Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/29643
Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ......................................................................
soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check
soc_pch_pirq_init() function is only getting compiled for RAMSTAGE hence remove unused __SIMPLE_DEVICE__ check.
Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/cannonlake/lpc.c M src/soc/intel/icelake/lpc.c 2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29643/1
diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index 84a2138..83d9cea 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -145,6 +145,7 @@
void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; const config_t *config = dev->chip_info; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];
@@ -158,11 +159,7 @@ pch_interrupt_routing[7] = config->pirqh_routing;
itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0;
diff --git a/src/soc/intel/icelake/lpc.c b/src/soc/intel/icelake/lpc.c index 8859c5d..63677c8 100644 --- a/src/soc/intel/icelake/lpc.c +++ b/src/soc/intel/icelake/lpc.c @@ -143,6 +143,7 @@
void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; const config_t *config = dev->chip_info; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];
@@ -156,11 +157,7 @@ pch_interrupt_routing[7] = config->pirqh_routing;
itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0;