Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Paul Menzel, Reka Norman, Tim Wawrzynczak, Boris Mittelberg.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73249 )
Change subject: Reland drivers/intel/dptf: Add multiple fan support under dptf ......................................................................
Patch Set 4:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73249/comment/9c6bac43_104e3008 PS3, Line 13: Gmeet
Please use Google Meet.
Ack
https://review.coreboot.org/c/coreboot/+/73249/comment/465ba3df_5d3cb1dc PS3, Line 15: as per the expectation
as expected
Done
https://review.coreboot.org/c/coreboot/+/73249/comment/cf4eb3fd_db1086ba PS3, Line 16: the
an
Ack
https://review.coreboot.org/c/coreboot/+/73249/comment/32694cc8_213b31d8 PS3, Line 16: observed
is observed
Done
https://review.coreboot.org/c/coreboot/+/73249/comment/267799e6_15d9ef29 PS3, Line 18: observed
is observed
Done
https://review.coreboot.org/c/coreboot/+/73249/comment/a0c3198f_c300d07a PS3, Line 18: AlderLake
Alder Lake
Ack
https://review.coreboot.org/c/coreboot/+/73249/comment/3b3fbaa4_8004546f PS3, Line 22:
Thank you for the detailed problem description. […]
As already explained in commit message with details as "With the fix in dptf driver where fan configures appropriate setting for only fan participant, able to see consistent 720p resolution." , will add more information on this.
https://review.coreboot.org/c/coreboot/+/73249/comment/187ec58c_6f45d44f PS3, Line 25: Alderlake
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/73249/comment/5b8227f6_3b86b668 PS3, Line 26: Alderlake
Ditto.
Done
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/73249/comment/90856932_4a60f953 PS3, Line 128: speed
Please append the unit: speed_rpm.
We have already added comment above for unit so would request to keep it as speed only here to make variable name short and simple. Also, the same way is being used across dptf driver related files. Hope this should be fine. Thanks.
https://review.coreboot.org/c/coreboot/+/73249/comment/40ff798d_b92810f1 PS3, Line 130: noise_level
Ditto.
Shared information above.
https://review.coreboot.org/c/coreboot/+/73249/comment/59579794_daf0300f PS3, Line 132: power
Ditto.
Shared information above.