HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42650 )
Change subject: sb/intel/i82801gx: Move `acpi_fill_fadt` to fadt.c ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 35: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 44: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 51: 0 ACPI_ADDRESS_SPACE_MEMORY
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 58: 1 ACPI_ADDRESS_SPACE_IO
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 65: 0 ACPI_ADDRESS_SPACE_MEMORY ....