Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem...
PS4, Line 83:
: /* GPP_B0 - NC/TP */
: PAD_NC(GPP_B0, UP_20K),
:
: /* GPP_B1 - NC/TP */
: PAD_NC(GPP_B1, UP_20K),
I have no idea if they are actually NC.
according to the schematics they are (TP only)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c2ab936256d0031d7a127fbeac42c8951a0b39f
Gerrit-Change-Number: 47191
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 21:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment