Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32515 )
Change subject: purism/librem_skl: remove 13v3 target, clean up Kconfig ......................................................................
Patch Set 2:
(3 comments)
Looks good but I'm confused about the MAINBOARD_VERSION drop.
https://review.coreboot.org/#/c/32515/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32515/2//COMMIT_MSG@15 PS2, Line 15: - remove redundant MAINBOARD_VERSION option How is it redundant? I didn't find another place where it is set.
https://review.coreboot.org/#/c/32515/2//COMMIT_MSG@16 PS2, Line 16: - specify microcode length separately for SKL and KBL devices I'm just wondering. This is only needed for FSP_CAR, right? It's neither the default nor would I expect Purism to use it. So you could probably save yourself some time, maintaining it.
https://review.coreboot.org/#/c/32515/2/src/mainboard/purism/librem_skl/Kcon... File src/mainboard/purism/librem_skl/Kconfig:
https://review.coreboot.org/#/c/32515/2/src/mainboard/purism/librem_skl/Kcon... PS2, Line 36: default "Librem 13 v2/v3" if BOARD_PURISM_LIBREM13_V2 NB. AIUI, this also alters the SMBIOS_PRODUCT_NAME which is sometimes used in OS's to handle quirks.